Add _routing to SQL includes list #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
acarbonetto
requested review from
GumpacG,
MaxKsyunz,
Yury-Fridlyand and
forestmvey
as code owners
Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## integ-metafields-routing #277 +/- ##
===========================================================
Coverage 97.33% 97.34%
- Complexity 4408 4409 +1
===========================================================
Files 388 388
Lines 10938 10940 +2
Branches 773 774 +1
===========================================================
+ Hits 10647 10649 +2
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| @Test | ||
| public void testMetafieldIdentifierRoutingTest() throws IOException { | ||
| // create an index, but the contents doesn't matter |
There was a problem hiding this comment.
Suggested change
| // create an index, but the contents doesn't matter | |
| // create an index, but the contents don't matter |
MitchellGale
approved these changes
Jun 19, 2023
forestmvey
approved these changes
Jun 19, 2023
matthewryanwells
approved these changes
Jun 19, 2023
GumpacG
approved these changes
Jun 19, 2023
Yury-Fridlyand
approved these changes
Jun 19, 2023
| builder.put(METADATA_FIELD_MAXSCORE, maxScore); | ||
| } | ||
| } else { // if (metaDataField.equals(METADATA_FIELD_SORT)) { | ||
| } else if (metaDataField.equals(METADATA_FIELD_SORT)) { |
matthewryanwells
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update IT index Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update doctest Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Add WHERE clause IT tests Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix IT test Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Update documentation for _routing Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
MitchellGale
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update IT index Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update doctest Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Add WHERE clause IT tests Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix IT test Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Update documentation for _routing Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update IT index Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update doctest Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Add WHERE clause IT tests Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix IT test Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Update documentation for _routing Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
that referenced
this pull request
Jul 12, 2023
…pensearch-project#1831) * Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update IT index Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update doctest Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Add WHERE clause IT tests Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix IT test Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Update documentation for _routing Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: acarbonetto <andrewc@bitquilltech.com> (cherry picked from commit 876a9c8) Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
MitchellGale
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update IT index Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update doctest Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Add WHERE clause IT tests Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix IT test Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Update documentation for _routing Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 22, 2023
…pensearch-project#1843) * Add _routing to SQL includes list Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update IT index Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Update doctest Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Add WHERE clause IT tests Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Fix IT test Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * Update documentation for _routing Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: acarbonetto <andrewc@bitquilltech.com> (cherry picked from commit 876a9c8) Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
_routingreserved word as a metafield accessible as an identifier from any opensearch index.Example:
Example response:
Issues Resolved
Partially resolves: sql#1478
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.